Reviewing merge request #163: JS rework for cleaner destruction of js bound objects
- Let the GC handle the lifetime of context based objects, destroy them though if they're not freed by JS
- Don't rely on keepContext anymore, use ScriptContext::hasAttachedObjects
- Fixed a lingering problem in the destruction of property-listeners (oops)
- Requested by:
Patrick Stählin - Status: Closed
- Source repository: packis-dss-mainline:js_manager
- Target repository: dss-mainline:master
- Created at: August 24th, 2010 21:25
Commits that would be merged:
- 1c56058
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
1c56058-cbe7ae4Comments
+ void blockingCallback() {
as discussed with patrick, rename these to startBlockingCall() and endBlockingCall()
Johannes Winkelmann |
2010-08-25 11:59:26 UTC
on core/scripting/jssocket.cpp
Tests do not succeed:
unknown location(0): fatal error in “testSendFrameWorksWithIncomingFrame”: memory access violation at address: 0x00000099: no mapping at fault address
/home/jin/Work/Projects/digitalSTROM/DSS/merge/dss-mainline/tests/jsds485tests.cpp(112): last checkpoint
*** 1 failure detected in test suite “Master Test Suite”
Running for the second time asserts:
[2010-08-31 15:11:33][Debug] [EventInterpreter] Logchannel destroyed
dsstests: /usr/include/boost/smart_ptr/shared_ptr.hpp:418: T* boost::shared_ptr< <template-parameter-1-1> >::operator->() const [with T = dss::PropertyNode]: Assertion `px != 0' failed.
unknown location(0): fatal error in “testEventHandlerJavascriptDoesntLeakExceptionsWithNonexistingFile”: signal: SIGABRT (application abort requested)
/home/jin/Work/Projects/digitalSTROM/DSS/merge/dss-mainline/tests/eventtests.cpp(264): last checkpoint
[2010-08-31 15:11:33][Debug] [EventInterpreter] Logchannel created
Something seems to be not right here…
Merged with changes.
Fixed the assert, renamed functions as discussed.
Add a new comment:
Login or create an account to post a comment