Reviewing merge request #151: Implemented clean shutdown
Implements #48
All threads and threaded subsystems will be properly shut down on SIGINT and SIGTERM signals.
- Requested by:
Sergey Bostandzhyan - Status: Closed
- Source repository: jins-dss-mainline:shutdown-48
- Target repository: dss-mainline:master
- Created at: July 21st, 2010 10:33
Commits that would be merged:
Version 2
- 888ca67
- 44200bf
- 7df6633
- 7aaf954
- f6b00c1
- 8453872
- 65f7e21
Removed forgotten debug printfs
First version of clean shutdown
Fixed a problem with thread names
Made subsystem name == thread name
Rework according to Patricks suggestions.
Lowered soap accept timeout from 4 to 2 seconds
Showing
888ca67-44200bfComments
+ std::string &getThreadIdentifier() { return m_Name; }
I'd add a const before std::string to avoid modification of the thread-identifier. And the & should stick to std::string.
+ bool m_shutdownFlag;
Shouldn’t that variable be named m_ShutdownFlag?
+ virtual void cleanup() {}
As far as I can see this function’s only used by BonjourHandler. I'd implement a specialized function in this class rather than include a new function in a base-class.
Updated merge request according to above comments.
Resolved conflicts/merged.
Add a new comment:
Login or create an account to post a comment