Reviewing merge request #150: Testcoverage bumped to 60%

Commits that would be merged:

Version 2
  • Version 1
  • Version 2
  • 98a6bc4
  • Patrick Stählin
over 1 year ago
  • 1a7f74f
  • Patrick Stählin
over 1 year ago
  • b778a56
  • Patrick Stählin
over 1 year ago
  • 9806e96
  • Patrick Stählin
over 1 year ago
  • 87cc43e
  • Patrick Stählin
over 1 year ago
  • 9362004
  • Patrick Stählin
over 1 year ago
  • f907705
  • Patrick Stählin
over 1 year ago
  • 642ed52
  • Patrick Stählin
over 1 year ago
  • 4e1577e
  • Patrick Stählin
over 1 year ago
  • a76d9b5
  • Patrick Stählin
over 1 year ago
  • 074fe7c
  • Patrick Stählin
over 1 year ago
  • 2234831
  • Patrick Stählin
over 1 year ago
Showing 888ca67-98a6bc4

Comments

This patch is needed in order to compile the MR, the tests then compile and run without errors:

diff —git a/tests/ds485tests.cpp b/tests/ds485tests.cpp
index d87d3ab..a4dd455 100644
—– a/tests/ds485tests.cpp
+++ b/tests/ds485tests.cpp
@@ -186,7 +186,7 @@ BOOST_AUTO_TEST_CASE(testSendingFrameWithEmptyPayload) {
ModelMaintenance maintenance(NULL);
maintenance.setApartment(&apt);
maintenance.initialize();
– DS485Proxy proxy(NULL, &maintenance);
+ DS485Proxy proxy(NULL, &maintenance, NULL);
proxy.setInitializeDS485Controller(false);
proxy.initialize();
DS485CommandFrame frame;

Please let me know if this is what you want or otherwise provide a patch if I missed the “bigger picture”.

Rebased to master and updated, compiles fine here now…

→ State changed from Open to Closed

Merged.

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository