Reviewing merge request #150: Testcoverage bumped to 60%
Commits that would be merged:
- 888ca67
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
888ca67-98a6bc4Comments
This patch is needed in order to compile the MR, the tests then compile and run without errors:
diff —git a/tests/ds485tests.cpp b/tests/ds485tests.cpp
index d87d3ab..a4dd455 100644
—– a/tests/ds485tests.cpp
+++ b/tests/ds485tests.cpp
@@ -186,7 +186,7 @@ BOOST_AUTO_TEST_CASE(testSendingFrameWithEmptyPayload) {
ModelMaintenance maintenance(NULL);
maintenance.setApartment(&apt);
maintenance.initialize();
– DS485Proxy proxy(NULL, &maintenance);
+ DS485Proxy proxy(NULL, &maintenance, NULL);
proxy.setInitializeDS485Controller(false);
proxy.initialize();
DS485CommandFrame frame;
Please let me know if this is what you want or otherwise provide a patch if I missed the “bigger picture”.
Rebased to master and updated, compiles fine here now…
Merged.


Add a new comment:
Login or create an account to post a comment